Add `--no-abi` flag to `sncast` `declare`, `declare-from` & `deploy` by die-herdplatte · Pull Request #4269 · foundry-rs/starknet-foundry

die-herdplatte · 2026-04-10T18:00:44Z

This feature simply erases the ABI before computing the class hash, as implemented in starkli.

I didn't change the declare interface in sncast_std for now since that would be a breaking change.

This feature simply erases the ABI before computing the class hash, as implemented in `starkli`.

franciszekjob

Hey @die-herdplatte 👋 , thanks for submitting this PR - it looks good! Please take a look at the comments.

franciszekjob · 2026-04-20T21:53:39Z

When --no-abi is used, the declared class hash points to a class with an empty ABI. However, the generated deploy suggestion can still include --arguments, which requires sncast to fetch the ABI from that class hash in order to transform Cairo-like arguments into calldata. That suggested command will therefore fail or be misleading for classes with constructor args.

e.g. (constructor params x: felt252, y: felt252):

➜ no_abi_testing git:(main) ✗ ../target/debug/sncast declare --contract-name=HelloStarknet --no-abi --network sepolia Compiling no_abi_testing v0.1.0 (/Users/franciszekjob/Projects/SWM/starknet-foundry/.worktrees/declare-no-abi/no_abi_testing/Scarb.toml) Finished `release` profile target(s) in 0 seconds Success: Declaration completed Class Hash: 0x1ef0773957778f0060d0c276745679e144227d0343f6c91cd0f8a3f7713fda8 Transaction Hash: 0x1e7217a6799be480aff1384062c1bf67d39c11721c14871b8cc52643c90a053 To see declaration details, visit: class: https://sepolia.voyager.online/class/0x01ef0773957778f0060d0c276745679e144227d0343f6c91cd0f8a3f7713fda8 transaction: https://sepolia.voyager.online/tx/0x01e7217a6799be480aff1384062c1bf67d39c11721c14871b8cc52643c90a053 To deploy a contract of this class, replace the placeholders in `--arguments` with your actual values, then run: sncast deploy --class-hash 0x1ef0773957778f0060d0c276745679e144227d0343f6c91cd0f8a3f7713fda8 --arguments '<x: felt252>, <y: felt252>' --network sepolia ➜ no_abi_testing git:(main) ✗ ../target/debug/sncast deploy --class-hash 0x1ef0773957778f0060d0c276745679e144227d0343f6c91cd0f8a3f7713fda8 --arguments '10, 20' --url http://188.34.188.184:7070/rpc/v0_10 Error: Error while processing Cairo-like calldata Caused by: Invalid number of arguments: passed 2, expected 0

I think we should either omit the --arguments hint when --no-abi is passed, or preferably switch the suggestion to raw --constructor-calldata placeholders, since raw calldata does not depend on the ABI.

Similar problem occurs when --no-abi is used with deploy --contract-name ... --arguments ...

e.g.

➜ no_abi_testing git:(main) ✗ ../target/debug/sncast --no-abi --contract-name HelloStarknet --arguments '10, 20, 30' --network sepolia Compiling no_abi_testing v0.1.0 (/Users/franciszekjob/Projects/SWM/starknet-foundry/.worktrees/declare-no-abi/no_abi_testing/Scarb.toml) Finished `release` profile target(s) in 0 seconds Error: Error while processing Cairo-like calldata Caused by: Invalid number of arguments: passed 3, expected 0

franciszekjob · 2026-04-20T22:09:28Z

+    /// If passed, omits ABI from the declared Sierra class. This changes the resulting class hash
+    #[arg(long)]
+    pub no_abi: bool,
+


Keeping this in the common args works, but I think it may be clearer to move no_abi onto the concrete command structs instead, for example Declare and DeclareFrom.

In particular, for declare-from, putting the flag closer to the --sierra-file path would let us express the constraint more naturally and avoid this manual validation:

if declare_from.sierra_file.is_none() && declare_from.common.no_abi { bail!("`--no-abi` can only be used with `--sierra-file`"); }

franciszekjob · 2026-04-20T22:16:42Z

+## `--no-abi`
+
+Optional.
+
+If passed, omits ABI from the declared class. This changes the resulting class hash.
+


Suggested change

## `--no-abi`

Optional.

If passed, omits ABI from the declared class. This changes the resulting class hash.

## `--no-abi`

Optional.

If passed, omits ABI from the declared class. This changes the resulting class hash.

Can only be used with `--sierra-file`.

I didn't add this because the network-mode-only arguments (--block-id, --source-url, --source-network) also don't have this hint

I see. Could you please add them then?

franciszekjob · 2026-04-20T22:20:51Z

Let's add tests cases for:

deploy --contract-name --no-abi --arguments ...

deploy --contract-name --no-abi --constructor-calldata ...

franciszekjob · 2026-04-27T10:15:23Z

Hi @die-herdplatte, are you going to address the changes from review?

die-herdplatte · 2026-04-28T17:15:14Z

Thanks for the review!
Yes, I'll update the PR this week.

…`sncast declare`

…ore a deploy Also fixes `--arguments` operating on an empty ABI when `--no-abi` is set

Allows clap to validate the mutual exclusivity

…or-calldata`

ddoktorski

Hi @die-herdplatte
Thanks for opening the PR! I've left a few comments that need to be addressed before merging 🙏

ddoktorski · 2026-05-11T11:02:56Z


    /// Class hash of contract declared on a different Starknet instance
-    #[arg(short = 'g', long)]
+    #[arg(short = 'g', long, conflicts_with_all = ["no_abi"])]


Suggested change

#[arg(short = 'g', long, conflicts_with_all = ["no_abi"])]

#[arg(short = 'g', long, conflicts_with = "no_abi")]

ddoktorski · 2026-05-11T11:21:23Z

 use std::fs;
 use test_case::test_case;

+pub fn get_declared_class_hash_from_json_output(output: &[u8]) -> Felt {


Let's move this function to tests/helpers/output.rs (new file needs to be created)

ddoktorski · 2026-05-11T12:21:49Z

    pub arguments: Option<String>,
 }

+enum AbiOrContractClass<C> {


Please remove this enum and add a function similar to:

fn abi_from_contract_class(contract_class: &ContractClass) -> Result<Vec<AbiEntry>> { let ContractClass::Sierra(sierra_class) = contract_class else { bail!("Transformation of arguments is not available for Cairo Zero contracts") }; serde_json::from_str(sierra_class.abi.as_str()) .context("Couldn't deserialize ABI received from network") }

then replace all occurrences of AbiOrContractClass::ContractClass with a call to this function

ddoktorski · 2026-05-11T12:41:22Z

+struct ConstructorArgs {
+    cairo_args: String,
+    typ: ConstructorArgsType,
+}
+
+#[derive(Clone, Serialize, Deserialize, Debug, PartialEq)]
+enum ConstructorArgsType {
+    CairoLike,
+    RawCalldata,
+}


It seems that it can be made as single enum:

Suggested change

struct ConstructorArgs {

cairo_args: String,

typ: ConstructorArgsType,

}

#[derive(Clone, Serialize, Deserialize, Debug, PartialEq)]

enum ConstructorArgsType {

CairoLike,

RawCalldata,

}

enum ConstructorArgs {

CairoLike(String),

RawCalldata(String),

}

ddoktorski · 2026-05-11T12:46:24Z

+}
+
+impl ConstructorArgs {
+    fn from_abi(abi: &[AbiEntry], no_abi: bool) -> Option<Self> {


Suggested change

fn from_abi(abi: &[AbiEntry], no_abi: bool) -> Option<Self> {

fn from_abi(abi: &[AbiEntry], abi_in_declared_class: bool) -> Option<Self> {

Also requires relevant changes in the logic

die-herdplatte added 2 commits April 10, 2026 19:45

Add --no-abi flag to sncast declare, declare-from & deploy

a1f3717

This feature simply erases the ABI before computing the class hash, as implemented in `starkli`.

Update CHANGELOG.md

c714dc4

die-herdplatte requested review from a team, DelevoXDG and ddoktorski April 10, 2026 18:00

franciszekjob reviewed Apr 20, 2026

View reviewed changes

die-herdplatte added 6 commits April 29, 2026 15:52

Fix hint generation for sncast deploy when --no-abi is passed to …

88e644f

…`sncast declare`

Merge remote-tracking branch 'upstream/master' into declare-no-abi

fcf2075

Use local ABI instead of fetching when contract class is declared bef…

399f5d3

…ore a deploy Also fixes `--arguments` operating on an empty ABI when `--no-abi` is set

Move --no-abi to command-specific instead of common args

99bc434

Allows clap to validate the mutual exclusivity

Add mutual exclusivity comments to declare-from docs

8075cd6

Add test case for `sncast deploy --contract-name --no-abi --construct…

d022941

…or-calldata`

die-herdplatte requested a review from franciszekjob April 29, 2026 15:48

scarb fmt

979f2c9

franciszekjob approved these changes May 10, 2026

View reviewed changes

ddoktorski requested changes May 11, 2026

View reviewed changes

	#[arg(short = 'g', long, conflicts_with_all = ["no_abi"])]
	#[arg(short = 'g', long, conflicts_with = "no_abi")]

	fn from_abi(abi: &[AbiEntry], no_abi: bool) -> Option<Self> {
	fn from_abi(abi: &[AbiEntry], abi_in_declared_class: bool) -> Option<Self> {

Conversation

die-herdplatte commented Apr 10, 2026

Uh oh!

franciszekjob left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

franciszekjob commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

die-herdplatte commented Apr 28, 2026

Uh oh!

ddoktorski left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

franciszekjob commented Apr 27, 2026 •

edited

Loading